This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] power8 patches, patch #2, add crypto builtins
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Pat Haugen <pthaugen at us dot ibm dot com>, Peter Bergner <bergner at vnet dot ibm dot com>
- Date: Wed, 22 May 2013 23:41:44 -0400
- Subject: Re: [PATCH, rs6000] power8 patches, patch #2, add crypto builtins
- References: <20130520204053 dot GA21090 at ibm-tiger dot the-meissners dot org> <20130520231307 dot GA538 at ibm-tiger dot the-meissners dot org> <CAGWvnym9RaCJP7mua_2uika0iJbVLKnCejcqXY1F8PtE751=Jg at mail dot gmail dot com>
Mike,
When you committed the patch, you did not add the new rs6000/crypto.md
file to the repository.
- David
On Tue, May 21, 2013 at 11:30 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> On Mon, May 20, 2013 at 7:13 PM, Michael Meissner
> <meissner@linux.vnet.ibm.com> wrote:
>> This patch adds the builtins for the new ISA 2.07 crypto instructions. It
>> bootstraps and causes no regressions, is it ok to install after patch #1 has
>> been applied?
>>
>> [gcc]
>> 2013-05-20 Michael Meissner <meissner@linux.vnet.ibm.com>
>>
>> * doc/extend.texi (PowerPC AltiVec/VSX Built-in Functions): Add
>> documentation for the power8 crypto builtins.
>>
>> * config/rs6000/t-rs6000 (MD_INCLUDES): Add crypto.md.
>>
>> * config/rs6000/rs6000-builtin.def (BU_P8V_AV_1): Add support
>> macros for defining power8 builtin functions.
>> (BU_P8V_AV_2): Likewise.
>> (BU_P8V_AV_P): Likewise.
>> (BU_P8V_VSX_1): Likewise.
>> (BU_P8V_OVERLOAD_1): Likewise.
>> (BU_P8V_OVERLOAD_2): Likewise.
>> (BU_CRYPTO_1): Likewise.
>> (BU_CRYPTO_2): Likewise.
>> (BU_CRYPTO_3): Likewise.
>> (BU_CRYPTO_OVERLOAD_1): Likewise.
>> (BU_CRYPTO_OVERLOAD_2): Likewise.
>> (XSCVSPDP): Fix typo, point to the correct instruction.
>> (VCIPHER): Add power8 crypto builtins.
>> (VCIPHERLAST): Likewise.
>> (VNCIPHER): Likewise.
>> (VNCIPHERLAST): Likewise.
>> (VPMSUMB): Likewise.
>> (VPMSUMH): Likewise.
>> (VPMSUMW): Likewise.
>> (VPERMXOR_V2DI): Likewise.
>> (VPERMXOR_V4SI: Likewise.
>> (VPERMXOR_V8HI: Likewise.
>> (VPERMXOR_V16QI: Likewise.
>> (VSHASIGMAW): Likewise.
>> (VSHASIGMAD): Likewise.
>> (VPMSUM): Likewise.
>> (VPERMXOR): Likewise.
>> (VSHASIGMA): Likewise.
>>
>> * config/rs6000/rs6000-c.c (rs6000_target_modify_macros): Define
>> __CRYPTO__ if the crypto instructions are available.
>> (altivec_overloaded_builtins): Add support for overloaded power8
>> builtins.
>>
>> * config/rs6000/rs6000.c (rs6000_expand_ternop_builtin): Add
>> support for power8 crypto builtins.
>> (builtin_function_type): Likewise.
>> (altivec_init_builtins): Add support for builtins that take vector
>> long long (V2DI) arguments.
>>
>> * config/rs6000/crypto.md: New file, define power8 crypto
>> instructions.
>>
>> [gcc/testsuite]
>> 2013-05-20 Michael Meissner <meissner@linux.vnet.ibm.com>
>>
>> * gcc.target/powerpc/crypto-builtin-1.c: New file, test for power8
>> crypto builtins.
>
> Patch #2 is okay.
>
> Thanks, David