This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: *ping* Re: [PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop
- From: Tom Tromey <tromey at redhat dot com>
- To: Shakthi Kannan <skannan at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 22 May 2013 09:23:23 -0600
- Subject: Re: *ping* Re: [PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop
- References: <1727363575 dot 9580702 dot 1368168907851 dot JavaMail dot root at redhat dot com> <1679064113 dot 5638738 dot 1369204271480 dot JavaMail dot root at redhat dot com>
>>>>> "Shakthi" == Shakthi Kannan <skannan@redhat.com> writes:
Shakthi> Is the following patch okay for trunk?
I still think it needs a test case.
I also don't recall -- did you check to see if the column number that is
emitted is actually correct?
You may want to change the Subject line of your note, as well.
The bug is filed against the preprocessor but it would have to be
reviewed by a diagnostics maintainer.
Tom