Re: PATCH: contrib/repro_fail: filter out "-ignore SIGHUP" from spawn line

[David Malcolm <dmalcolm at redhat dot com>]

On Mon, 2013-05-06 at 12:02 -0400, David Malcolm wrote:
> On Thu, 2013-04-25 at 14:10 -0400, David Malcolm wrote:
> > On Thu, 2013-04-25 at 13:43 -0400, Diego Novillo wrote:
> > > On 2013-04-25 12:30 , David Malcolm wrote:
> > > 
> > > > diff --git a/contrib/ChangeLog b/contrib/ChangeLog
> > > > index 9f4505b..01afcb5 100644
> > > > --- a/contrib/ChangeLog
> > > > +++ b/contrib/ChangeLog
> > > > @@ -1,3 +1,7 @@
> > > > +2013-04-25  David Malcolm  <dmalcolm@redhat.com>
> > > > +
> > > > +    * repro_fail: filter out "-ignore SIGHUP" from the spawn lines
> > > > +
> > > 
> > > This is OK, thanks.  It works with the regular spawn lines too, right?  
> > > (looks like it should).
> > 
> > All of the spawn lines in my.log files have the "-ignore SIGHUP", so I
> > hand-edited some to remove that part, and it does indeed work on such
> > lines.

Ping: OK if I commit this to trunk?

> BTW, I don't have commit rights to GCC (am reattaching the patch for
> convenience)

(I have svn rights now)

> [I believe the copyright assignment requirements are covered by an
> agreement the FSF has with my employer (Red Hat)]

> FWIW the "-ignore SIGHUP" I ran into appears to come from a patch
> applied downstream in Fedora packages of DejaGnu [1], but which appears
> to be effectively the same as one that's in DejaGnu git (albeit not yet
> within a released tarball):
> http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=commitdiff;h=50a378f626fcdbaf30202a36bf73738de08a53bf
> 
>     2011-03-15  H.J. Lu  <hjl.tools@gmail.com>
>     
>         * lib/remote.exp (local_exec): Ignore SIGHUP.
> 
> so if I'm reading this right, any attempt to run repro_fail by someone
> using a git build of dejagnu needs the patch.
> 
> Hope this is helpful
> Dave
> 
> [1]
> http://pkgs.fedoraproject.org/cgit/dejagnu.git/diff/dejagnu-1.5-smp-1.patch?h=f17&id=0c9228fc0093b3de82defbd8de02a65d4ae5f526
>