This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Implement std::make_unique


On 18 May 2013 16:36, Paolo Carlini wrote:
>
> Great! Don't we want it inline?

This makes make_unique() inline and adds doxygen comments to
unique_ptr.  I don't remember why I split the
unique_ptr<T[],D>::reset() function into two overloads back in
December, so this combines them into one again, matching how they're
declared in the standard.

        * include/bits/unique_ptr.h (make_unique): Declare inline.
        (unique_ptr<T[],D>::reset()): Combine two overloads into one.
        (default_delete, unique_ptr): Add doxygen comments.
        * include/bits/shared_ptr_base.h: Improve doxygen comments.
        * include/bits/shared_ptr.h: Likewise.
        * testsuite/20_util/default_delete/48631_neg.cc: Adjust dg-error line
        number.
        * testsuite/20_util/unique_ptr/assign/48635_neg.cc: Likewise.

Tested x86_64-linux, committed to trunk.

Attachment: patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]