This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: new port: msp430-elf, revision 2


On Fri, 10 May 2013, DJ Delorie wrote:
> Index: MAINTAINERS
> ===================================================================
> +msp430 port		DJ Delorie		dj@redhat.com
> +msp430 port		Nick Clifton		nickc@redhat.com

I'll bring this up on the steering committee (not that I expect
a lot of discussion :-).

> Index: gcc/doc/invoke.texi
> ===================================================================
> +Link the simulator runtime libraries.

"run-time", according to my reading of
http://gcc.gnu.org/codingconventions.html .

> +@item -masm-hex
> +@opindex masm-hex
> +Force assembly output to always use hex constants instead of decimal.

Here I am wondering whether to simply omit "instead of decimal"?  (If
not, somehow that part of the sentence comes across as a bit odd, but
then I'm not a native speaker.)

> +@item -mmcu=
> +@opindex mmcu=
> +Select the MCU to target.  Note that there are two ``generic'' MCUs,
> +@code{msp430} and @code{msp430x}, which should be used most of the
> +time.  This option is also passed to the assembler.

What are the other legitimate options beyond these two?

> +@item -mrelax
> +@opindex mrelax
> +Perform link-time opcode relaxing.

Will everyone know what opcode relaxing is?

> Index: gcc/doc/md.texi
> ===================================================================
> +@item Ya
> +Memory reference, any type, but restricted 64k range of constants.

"restricted 64k range of constants", what's that?  And kBit or kByte?


The doc changes look fine modulo the above, and I assume you'll want
to add a note to the release notes htdocs/gcc-4.9/changes.html and a
news item to htdocs/index.html .

Gerald


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]