This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)
- From: Teresa Johnson <tejohnson at google dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 3 May 2013 10:34:41 -0700
- Subject: Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)
- References: <CAGWvnynxWzPWvcoOfLWA7xMhMnH9P_QMGiX7OrMqbTODm3yDwQ at mail dot gmail dot com> <CAAe5K+X177QJEmxc79j_dHQoXteLyENaG8M9MWE+igCMwqX-Gw at mail dot gmail dot com> <5183F345 dot 3000906 at redhat dot com> <CAGWvnykmT7haMqGg+uy2Z7dLV+dmViakbM5=HgL0C-1ZhtY9DQ at mail dot gmail dot com>
On Fri, May 3, 2013 at 10:28 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> On Fri, May 3, 2013 at 1:26 PM, Jeff Law <law@redhat.com> wrote:
>> On 05/03/2013 11:15 AM, Teresa Johnson wrote:
>>>
>>> On Fri, May 3, 2013 at 9:37 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
>>>>
>>>> Thanks for the patch.
>>>>
>>>> Bootstrap works on x86 and Anton's testcase works on x86.
>>>>
>>>> Is there any testcase for x86 that would demonstrate the failure or
>>>> that could check the probabilities in a dump file and see the
>>>> inconsistency?
>>>
>>>
>>> Patch is committed. But I just figured out why it isn't showing up on
>>> x86 - it is because -fschedule-insns is not enabled by default. I can
>>> reproduce it with x86 using the same test case. Will go ahead and
>>> submit a patch to add this to the testsuite.
>>
>> Just an FYI, we don't use -fschedule-insns (first pass) on x86/x86_64 due to
>> register pressure issues. However, I think for the testsuite it'd be OK to
>> have a test which uses -fschedule-insns to expose the need for clamping on
>> the probabilities.
>
> Then Anton's testcase would make a good addition, with explicit
> -fschedule-insns.
Yep, getting that patch ready right now.
Teresa
>
> Thanks, David
--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413