This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix node weight updates during ipa-cp (issue7812053)
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Teresa Johnson <tejohnson at google dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, reply at codereview dot appspotmail dot com
- Date: Tue, 30 Apr 2013 08:50:45 -0700
- Subject: Re: [patch] Fix node weight updates during ipa-cp (issue7812053)
- References: <20130327172238 dot 545EF80580 at tjsboxrox dot mtv dot corp dot google dot com> <CAFiYyc1F7ncAXzN9eN3wuZzpZvk=mpKM7D4CcBt6hCKpeM1xtA at mail dot gmail dot com> <CAAe5K+WCmr8sqGgFm8vVqDGe5Xfe840jBn7Suf5ZGQkezO38Bg at mail dot gmail dot com> <CAMe9rOrM_f9FXimjDROU5CUDPzbELJ4bzinaoS8oqX=eKh5MdQ at mail dot gmail dot com> <CAAe5K+XcV1MT6wZVNCphuc1Mg+MEmJsOR0yLNyPJ4GTMuA=OUw at mail dot gmail dot com> <CAAe5K+WemjbyBgysqg8DDuqC1tNerPNVtwh-2kHnkq=JJ-phOA at mail dot gmail dot com> <CAMe9rOrqhGL3tny1uPDQWdibMgE5EvW35kQUvLU6PEWV0zmepQ at mail dot gmail dot com> <CAAe5K+X9Z+OeGDzgqXBacUYCnaNQh-XtM-QJbW3OHSvtrmXX0g at mail dot gmail dot com>
On Tue, Apr 30, 2013 at 7:02 AM, Teresa Johnson <tejohnson@google.com> wrote:
> On Mon, Apr 29, 2013 at 12:35 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Apr 29, 2013 at 10:31 AM, Teresa Johnson <tejohnson@google.com> wrote:
>>> FYI, Fixed in r198416.
>>>
>>> Thanks,
>>> Teresa
>>>
>>
>> I noticed that sometimes GCC generates:
>>
>> _8 = memcpy (ret_6, s_2(D), len_4);
>> _8 = memcpy (ret_6, s_2(D), len_4);
>> memcpy (_17, buffer_12(D), add_16);
>> memcpy (_17, buffer_12(D), add_16);
>> memcpy (_25, _28, _27);
>> memcpy (_25, _28, _27);
>> memcpy (_39, buffer_2, len_4);
>> memcpy (_39, buffer_2, len_4);
>> memcpy (_16, &fillbuf, pad_1);
>> memcpy (_16, &fillbuf, pad_1);
>
> I am getting this too with a profiledbootstrap with LTO. However, this
> isn't due to my changes. I had confirmed that after reverting my
> changes (r197595 and now the follow-on fix r198416) this problem still
> occurs.
>
> Teresa
There is a strayed debug_gimple_stmt. I am checking in this
patch to fix it.
--
H.J.
---
diff --git a/gcc/value-prof.c b/gcc/value-prof.c
index 3348d7f..b665b1c 100644
--- a/gcc/value-prof.c
+++ b/gcc/value-prof.c
@@ -416,7 +416,6 @@ stream_in_histogram_value (struct lto_input_block
*ib, gimple stmt)
new_val->n_counters = ncounters;
for (i = 0; i < ncounters; i++)
new_val->hvalue.counters[i] = streamer_read_gcov_count (ib);
- debug_gimple_stmt (stmt);
if (!next_p)
gimple_add_histogram_value (cfun, stmt, new_val);
else