This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix a -Wsign-compare warning in i386.c
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Henderson <rth at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 27 Apr 2013 10:33:13 +0200
- Subject: Re: [PATCH] Fix a -Wsign-compare warning in i386.c
- References: <20130426222318 dot GV28963 at tucnak dot redhat dot com>
On Sat, Apr 27, 2013 at 12:23 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> GCC 4.7.2 warns about -Wsign-compare when unsigned iterator is compared
> with cregs_size. GCC 4.8 doesn't warn about it (otherwise bootstrap would
> fail), because it calls maybe_constant_value before emitting the warning,
> but still I'd say it is better to use the same signedness.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2013-04-26 Jakub Jelinek <jakub@redhat.com>
>
> * config/i386/i386.c (ix86_expand_call): Make cregs_size unsigned.
OK - even obvious, I'd say.
Thanks,
Uros.