This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Maksim Kuznetsov <maks dot kuznetsov at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Segher Boessenkool <segher at kernel dot crashing dot org>, Michael Zolotukhin <michael dot v dot zolotukhin at gmail dot com>, hjl dot tools at gmail dot com, ubizjak at gmail dot com, izamyatin at gmail dot com, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Sergey Ostanevich <sergos dot gnu at gmail dot com>, law at redhat dot com, rth at redhat dot com
- Date: Tue, 16 Apr 2013 13:55:48 +0200
- Subject: Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output
- References: <CACRX5U+gDT+Z=tp6gYU2iwRe3wLp1s-8sjAX7p8tbxH=oDUxPQ at mail dot gmail dot com> <773CF015-2E8D-47DD-B25E-5C24B9F95B63 at kernel dot crashing dot org> <CACRX5UKyqAqS=zFROXEunQCzqdc93DfX_74OXsxY0et6KNb5nw at mail dot gmail dot com> <CACRX5UJbVCjwyWDH6VvMWCtqZRxaLLDUfk14osz-pZS=XhXHwg at mail dot gmail dot com> <CACRX5U+r8qsC8hZEUg_aU_UiV43c3JBGx7GWgmb-J_svdUMv_g at mail dot gmail dot com> <CANtU078qjAK-qQgjTjTBVve1hW9yCDjVbWNMcttU6yj9jkZx8A at mail dot gmail dot com> <1979C4C7-1452-4167-8F27-E746F1F05AA8 at kernel dot crashing dot org> <CANtU07-TiW5a6fduyOKfKCGfrEmrfDrCgfiTHX6-mm4hMQr8TA at mail dot gmail dot com> <CACRX5UJHYDJAahUKdJjjs8hvkzZV3s9YvV9tYqqGsq1WHMLNQQ at mail dot gmail dot com> <CACRX5U+rnLh0JfqJhLXrFvb_szR0gFtoGYwtAAsBkeMxAziOPA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Apr 16, 2013 at 03:41:52PM +0400, Maksim Kuznetsov wrote:
> Richard, Jeff, could you please have a look?
I wonder if it %{ and %} shouldn't be better handled in final.c
for all #ifdef ASSEMBLER_DIALECT targets, rather than just for one specific.
Also:
*(p + 1)
should be better written as p[1] (more readable).
Jakub