This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Debug, Fortran] RFC patch for DW_TAG_namelist (PR fortran/37132)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: gcc patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Wed, 10 Apr 2013 09:00:25 +0200
- Subject: Re: [Debug, Fortran] RFC patch for DW_TAG_namelist (PR fortran/37132)
- References: <5164937B dot 2040004 at net-b dot de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Apr 10, 2013 at 12:17:31AM +0200, Tobias Burnus wrote:
> +/* Output debug information for namelists. */
> +
> +void
> +dwarf2out_namelist_decl (const char *name, tree context,
> + vec<tree> *item_decls)
> +{
> + dw_die_ref scope_die, nml_die, nml_item_die, nml_item_ref_die;
> + tree item;
> + int i;
> +
> + if (debug_info_level <= DINFO_LEVEL_TERSE)
> + return;
> +
> + if (!(dwarf_version >= 2))
> + return;
Just a nit, GCC only supports DWARF {2,3,4} right now, DWARF1 support used
to be done using a different source file that is long removed, and as
DW_TAG_namelist* is already in DWARF2, there is no point to test whether
dwarf_version >= 2, it always is.
Also, if you are including a new header in debug.h, you need to adjust
dependencies in Makefile.in. As it didn't have any includes before,
replace all occurrences of debug.h with $(DEBUG_H) and add
DEBUG_H = debug.h $(VEC_H)
somewhere in between lines for other headers.
Jakub