RE: [PING^1] [AArch64] Implement Bitwise AND and Set Flags

["Ian Bolton" <ian dot bolton at arm dot com>]

> Please consider this as a reminder to review the patch posted at
> following link:-
> http://gcc.gnu.org/ml/gcc-patches/2013-01/msg01374.html
> 
> The patch is slightly modified to use CC_NZ mode instead of CC.
> 
> Please review the patch and let me know if its okay?
> 

Hi Naveen,

With the CC_NZ fix, the patch looks good apart from one thing:
the second "set" in each pattern should have the "=r,rk" constraint
rather than just "=r,r".

That said, I've attached a patch that provides more thorough test cases,
including execute ones.  When you get commit approval (which will be
after GCC goes into stage 1 again) then I can add in the test
cases.  You might as well run them now though, for more confidence
in your work.

BTW, I have an implementation of BICS that's been waiting for
GCC to hit stage 1.  I'll send that out for review soon.

NOTE: I do not have maintainer powers here, so you need someone else
to give the OK to your patch.

Cheers,
Ian

Attachment: aarch64-ands-tests-patch-v1.txt
Description: Text document