This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch testsuite]: Fix gcc.target/i386 cases for mingw-targets
2013/3/8 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> Hi Kai,
>
> some comments; I'll leave approval to a target maintainer.
>
>> Index: gcc.target/i386/movti.c
>> ===================================================================
>> --- gcc.target/i386/movti.c (Revision 196507)
>> +++ gcc.target/i386/movti.c (Arbeitskopie)
>> @@ -7,4 +7,4 @@ _Decimal128 test (void)
>> return 1234123412341234.123412341234dl;
>> }
>>
>> -/* { dg-final { scan-assembler-not "movabs" } } */
>> +/* { dg-final { scan-assembler-not "movabs" { target { !
>> x86_64-*-mingw* } } } } */
>
> Please add a comment why mingw64 is special here.
>
>> Index: gcc.target/i386/pr20020-1.c
>> ===================================================================
>> --- gcc.target/i386/pr20020-1.c (Revision 196507)
>> +++ gcc.target/i386/pr20020-1.c (Arbeitskopie)
>> @@ -1,5 +1,6 @@
>> /* Check that 128-bit struct's are represented as TImode values. */
>> /* { dg-do compile { target int128 } } */
>> +/* { dg-skip-if "" { x86_64-*-mingw* } { "*" } { "" } } */
>
> Please omit the default { "*" } { "" } here and in other tests below.
> And again: explain why the test is skipped.
Hmm, why shall I omit here the default. I checked in tree and most
statements for dg-skip-if are expressing default too.
Well, to skip here x64 mingw is caused by the fact that it has a
different ABI as x86_64. I will add it to skip message.
> Thanks.
> Rainer
Ok to apply with those changes?
Kai