Re: [PATCH] Fix valgrind checking bootstrap with PCH (PR middle-end/56461)

[Jakub Jelinek <jakub at redhat dot com>]

On Fri, Mar 01, 2013 at 09:16:16PM +0100, Jakub Jelinek wrote:
> Bootstrapped/regtested on x86_64-linux and i686-linux, tested also with
> valgrind checking on various testcases (full --enable-checking=yes,valgrind
> bootstrap queued for the weekend).

FYI, with this patch (first time I remember) the valgrind checking
bootstrap actually succeeded on x86_64-linux.
../configure --enable-languages=all,obj-c++,lto --enable-checking=yes,valgrind
make -j16 STAGE1_CFLAGS='-g -O2' STAGE1_CXXFLAGS='-g -O2' > LOG 2>&1 && make -j16 -k check > LOGC 2>&1; ../contrib/test_summary > LOGT 2>&1

Bootstrap took a few minutes under 24 hours, regtest a few minutes under 40
hours.

During regtesting some failures were seen (smaller amount of them
timeouts because I haven't increased the timeouts, bigger amounts because of
various valgrind errors, I'll go through them soon).
Compared to non-valgrind checking bootstrap the difference was:

                === gcc Summary ===
 
-# of expected passes           95837
-# of unexpected failures       32
+# of expected passes           94093
+# of unexpected failures       287
 # of unexpected successes      44
 # of expected failures         266
+# of unresolved testcases      26
 # of unsupported tests         1398

                === gfortran Summary ===
 
-# of expected passes           43273
-# of unexpected failures       6
+# of expected passes           43227
+# of unexpected failures       48
 # of unexpected successes      2
 # of expected failures         48
-# of unresolved testcases      6
+# of unresolved testcases      10
 # of unsupported tests         61

                === g++ Summary ===
 
-# of expected passes           53896
+# of expected passes           52584
+# of unexpected failures       84
 # of expected failures         290
+# of unresolved testcases      1
 # of unsupported tests         832

                === objc Summary ===
 
-# of expected passes           2988
+# of expected passes           2985
+# of unexpected failures       3
 # of expected failures         6
 # of unsupported tests         74

                === libstdc++ Summary ===
 
-# of expected passes           9246
+# of expected passes           9237
+# of unexpected failures       7
 # of expected failures         45
+# of unresolved testcases      2
 # of unsupported tests         212

> 2013-03-01  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR middle-end/56461
> 	* ggc-common.c (gt_pch_save): For ENABLE_VALGRIND_CHECKING,
> 	if VALGRIND_GET_VBITS is defined, temporarily make object
> 	memory all defined, and restore previous valgrind addressability
> 	and definability afterwards.  Free this_object at the end.
> 
> 	* c-pch.c (pch_init): Free target_validity at the end.

	Jakub