This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 55978: [4.8 Regression] class_optional_2.f90 -Os fails
- From: Thomas Koenig <tkoenig at netcologne dot de>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 06 Feb 2013 18:46:57 +0100
- Subject: Re: [Patch, Fortran] PR 55978: [4.8 Regression] class_optional_2.f90 -Os fails
- References: <CAKwh3qistP417Btc+0y44h5UC7pbN2tmoZuY+DMQ+d97fOGjpg@mail.gmail.com>
Hi Janus,
after Tobias' approval, two remarks:
One thing that you can do is to change this to
+ if (unlikely(source->base_addr == NULL))
+ return NULL;
to minimize the runtime impact.
As for a test case, a lot of test cases in class_optional_2.f90
are commented out. Some of these could probably be uncommented
now, but it is not too urgent now.
Regards
Thomas