This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix thinko in handle_error_attribute (PR middle-end/56167)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 5 Feb 2013 01:40:19 +0000
- Subject: Re: [PATCH] Fix thinko in handle_error_attribute (PR middle-end/56167)
- References: <20130204162511.GC4385@tucnak.redhat.com>
On Mon, 4 Feb 2013, Jakub Jelinek wrote:
> Hi!
>
> Without this fix, we were letting in invalid error/warning attributes,
> on function decls in addition to valid ones with STRING_CST argument also
> attributes with various bogus arguments, and for e.g. VAR_DECLs which
> shouldn't have any error/warning attributes those with STRING_CST arguments.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com