This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c
- From: Janis Johnson <janis_johnson at mentor dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: <janisjo at codesourcery dot com>, <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 23 Jan 2013 15:39:44 -0800
- Subject: Re: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c
- References: <50F980CE.6030609@mentor.com> <2987551.qUaChJ0c29@polaris>
- Reply-to: <janisjo at codesourcery dot com>
On 01/23/2013 02:52 PM, Eric Botcazou wrote:
>> Test gcc.dg/vect/vect-multitypes uses Tcl conditions within a dg-final
>> directive, which is something that DejaGnu handles but we strive not to
>> do. It's now possible to use supported constructs to get the same
>> result, so I've cleaned up the test and checked it in as obvious. I'm
>> fixing this particular test because I want to add an xfail but want to
>> keep that change separate from the cleanup.
>
> Something doesn't work anymore for SPARC though:
>
> ERROR: gcc.dg/vect/vect-multitypes-12.c: error executing dg-final: bad index
> "18-1": must be integer or end?-integer?
> UNRESOLVED: gcc.dg/vect/vect-multitypes-12.c: error executing dg-final: bad
> index "18-1": must be integer or end?-integer?
> ERROR: gcc.dg/vect/vect-multitypes-12.c -flto: error executing dg-final: bad
> index "18-1": must be integer or end?-integer?
> UNRESOLVED: gcc.dg/vect/vect-multitypes-12.c -flto: error executing dg-final:
> bad index "18-1": must be integer or end?-integer?
>
The error message comes from Tcl but I don't know what it's complaining
about and it works fine for me, even if I replace "sparc*-*-*" with
"arm*-*-*".
Would you mind playing around with it a bit, like removing the xfail from
/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target sparc*-*-* xfail ilp32 } } } */
and removing/disabling the directives with sparc*-*-*?
I had forgotten to move the comment above the replaced convoluted
directive: "/* bleah */". I see it's still appropriate.
Janis