This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: summarize kfails in dg-extract-results.sh


On Tue, Jan 15, 2013 at 12:22 PM, Janis Johnson
<janis_johnson@mentor.com> wrote:
> On 01/15/2013 09:24 AM, David Blaikie wrote:
>> For some reason KFAILs weren't being summarized by
>> dg-extract-results.sh. I assume this was just an oversight, so here's
>> a patch to add it alongside all the other result types.
>>
>> I encountered this in the GDB test suite but was asked to submit the
>> change upstream to GCC as GDB would prefer to avoid unnecessary local
>> changes to the script & this change seems general enough to go in to
>> GCC.
>>
>> (As was pointed out by Pedro Alves on the gdb-patches list, KFAIL
>> support was recently added by Doug Evans (
>> http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00996.html ), so KPASS
>> support seems like a natural complement)
>>
>> I'm still a little fuzzy on the specifics of ChangeLog lines, but
>> here's my attempt at one for this change:
>>
>>     * dg-extract-results.sh: Handle KPASSes.
>
> OK.  I checked it in.

Thanks - though while reviewing this I realize I'd made a mistake
(even in such a trivial patch - got muddled up somewhere along the way
from GDB 7.5 to GDB ToT to GCC ToT). It was accidentally printing out
the kfail count on the kpass line. Fix attached.

2013-01-15  David Blaikie <dblaikie@gmail.com>

        * dg-extract-results.sh: Print KPASS count correctly.

Attachment: gcc-extract-kpass.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]