This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Allow new ISL/CLooG versions
- From: Richard Biener <rguenther at suse dot de>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: Dominique Dhumieres <dominiq at lps dot ens dot fr>, gcc-patches at gcc dot gnu dot org, tobias at grosser dot es
- Date: Tue, 15 Jan 2013 10:24:14 +0100 (CET)
- Subject: Re: [PATCH] Allow new ISL/CLooG versions
- References: <20130114192712.BE33A3BE1B@mailhost.lps.ens.fr> <20130114202039.GA22255@bromo.med.uc.edu>
On Mon, 14 Jan 2013, Jack Howarth wrote:
> On Mon, Jan 14, 2013 at 08:27:12PM +0100, Dominique Dhumieres wrote:
> > In order to bootstrap r195167 with the new ISL/CLooG versions,
> > I had to apply the following patch:
> >
> > --- ../work/configure 2013-01-14 19:32:00.000000000 +0100
> > +++ configure 2013-01-14 19:42:15.000000000 +0100
> > @@ -5848,7 +5848,7 @@ else
> > int
> > main ()
> > {
> > -if (strncmp (isl_version (), "isl-0.10", strlen ("isl-0.10")) != 0)
> > +if (strncmp (isl_version (), "isl-0.11", strlen ("isl-0.11")) != 0)
> > return 1;
> >
> > ;
> > @@ -6033,7 +6033,7 @@ int
> > main ()
> > {
> > #if CLOOG_VERSION_MAJOR != 0 \
> > - || CLOOG_VERSION_MINOR != 17 \
> > + || CLOOG_VERSION_MINOR != 18 \
> > || CLOOG_VERSION_REVISION < 0
> > choke me
> > #endif
> >
> > (I didn't bother to update the messages: got
> > checking for version 0.10 of ISL... yes
> > checking for version 0.17.0 of CLooG... yes).
> >
> > Dominique
>
> Dominique,
> I believe that hack effectively changes...
>
> Index: configure.ac
> ===================================================================
> --- configure.ac (revision 195174)
> +++ configure.ac (working copy)
> @@ -1607,7 +1607,7 @@ if test "x$with_isl" != "xno" &&
> dnl with user input.
> ISL_INIT_FLAGS
> dnl The versions of ISL that work for Graphite
> - ISL_CHECK_VERSION(0,10)
> + ISL_CHECK_VERSION(0,11)
> if test "${gcc_cv_isl}" = no ; then
> ISL_CHECK_VERSION(0,11)
> fi
>
> Richard seems to be assuming that the second call to ISL_CHECK_VERSION(0,11)
> in configure.ac will rerun the isl checks on 0.11.x but I suspect this doesn't
> take in account the caching of the results from the first call to ISL_CHECK_VERSION().
> Certainly from my config.log against isl 0.11.1 and cloog 0.18.0, it appears that
> the version tests from the ISL_CHECK_VERSION(0,11) call aren't run and the
> cached result from the first ISL_CHECK_VERSION(0,10) is used instead.
True - I missed that. I re-tested allowing both versions only
with in-tree. I'm going to fix this.
Richard.