This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] PR55982 Fix buglet in __strncat_chk
- From: ppluzhnikov at google dot com (Paul Pluzhnikov)
- To: gcc-patches at gcc dot gnu dot org
- Cc: jakub at redhat dot com, ppluzhnikov at google dot com
- Date: Mon, 14 Jan 2013 16:57:42 -0800 (PST)
- Subject: [patch] PR55982 Fix buglet in __strncat_chk
Greetings,
In libssp/strncat-chk.c, the loop was unrolled 5 times (apparently by
accident).
Ok for trunk?
Thanks,
--
Paul Pluzhnikov
2013-01-14 Paul Pluzhnikov <ppluzhnikov@google.com>
PR 55982
* strncat-chk.c (__strncat_chk): Fix loop unroll.
Index: libssp/strncat-chk.c
===================================================================
--- libssp/strncat-chk.c (revision 195181)
+++ libssp/strncat-chk.c (working copy)
@@ -87,12 +87,6 @@ __strncat_chk (char *__restrict__ dest, const char
*++dest = c;
if (c == '\0')
return s;
- if (slen-- == 0)
- __chk_fail ();
- c = *src++;
- *++dest = c;
- if (c == '\0')
- return s;
} while (--n4 > 0);
n &= 3;
}