This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: unnecessary assert
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
- Date: Thu, 10 Jan 2013 00:50:49 +0100
- Subject: Re: unnecessary assert
- References: <55327D81-C743-4A22-890C-3FD6AC859577@comcast.net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Jan 09, 2013 at 02:57:00PM -0800, Mike Stump wrote:
> Ok for 2.8?
Not to 2.8, but to 4.8 it is ok.
> http://gcc.gnu.org/PR31150 is the PR when the assert was added, if you want to see it. svn+ssh://gcc.gnu.org/svn/gcc/trunk@142892 is the change itself.
That actually didn't add the assert, just moved it from lots lines later
(unconditional there) to the conditional spot here.
> 2013-01-09 Mike Stump <mikestump@comcast.net>
>
> * dse.c (record_store): Remove unnecessary assert.
>
> 2013-01-09 Mike Stump <mikestump@comcast.net>
>
> * dse.c (record_store): Remove unnecessary assert.
>
> --- dse.c (revision 195067)
> +++ dse.c (working copy)
> @@ -1495,10 +1495,7 @@ record_store (rtx body, bb_info_t bb_inf
> if (GET_MODE (mem) == BLKmode)
> width = MEM_SIZE (mem);
> else
> - {
> - width = GET_MODE_SIZE (GET_MODE (mem));
> - gcc_assert ((unsigned) width <= HOST_BITS_PER_WIDE_INT);
> - }
> + width = GET_MODE_SIZE (GET_MODE (mem));
>
> if (spill_alias_set)
> {
Jakub