This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] Fix PR53876 (regression), PR55990 (regression) and PR55992
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 6 Jan 2013 22:43:53 +0100
- Subject: Re: [Patch, fortran] Fix PR53876 (regression), PR55990 (regression) and PR55992
- References: <CAGkQGiKgb_Fbk+QxHexh8wMJK=XzTCsUBWjJ=QMH1_vBV5KX5A@mail.gmail.com> <50E98968.30209@net-b.de>
Indeed - all your nits are veritable nits. For some reason, I set the
working directory as PR55990 and kept referring to that :-) The
tescase was always checked with a local version but I did verify that
DejaGnu agreed that it worked.
Committed revision 194953
gnu central is taking its time about registering the commit, so I'll
close the PRs in the morning.
Thanks for the review
Paul
On 6 January 2013 15:25, Tobias Burnus <burnus@net-b.de> wrote:
> Paul Richard Thomas wrote:
>>
>> Boostratpped and regtested on FC17/x86_64 - OK for trunk?
>
>
> OK - with the below nits fixed. Thanks for the patch.
>
>
>
>> PR fortran/PR53876
>> PR fortran/PR55990
>> PR fortran/PR55992
>
>
> Change 55* into 54*.
>
>
>
>> PR fortran/PR53876
>> PR fortran/PR55990
>> PR fortran/PR55992
>
>
> Ditto.
>
>> + /* Ensure that the CLASS langauge specific flag is set. */
>
>
> s/langauge/language/
>
>> + ! { dg-do run}
>
>
> s/run}/run }/
>
> Without the " " before the right curly brace, DejaGNU will ignore the line
> and handle it as "dg-do compile". Please check after that change that the
> test case doesn't fail at run time.
>
> Tobias
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy