This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Bugfix: Additional parameter for canonicalize comparison
On 11/12/12 10:16, Kaz Kojima wrote:
> Andreas Krebbel <krebbel@linux.vnet.ibm.com> wrote:
>> urgs - I'll fix this. Is the patch ok with that change for sh?
>
> Yes, the sh portion is OK with that change, though it would be better
> to fix the users of sh_canonicalize_comparison instead of its wrapper
> as pointed out by rth and oleg.
For the backend internal uses sh_canonicalize_comparison has an additional 'mode' parameter. It is
not clear to me why this is actually needed. But "fixing" the users would involve getting rid of
this parameter. I didn't want to change that with this patch since it might change the original
behaviour. The patch hopefully is a NOP for the change back-ends.
-Andreas-