This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

On Thu, Dec 6, 2012 at 2:40 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:

> Ok, how about the following which bootstrapped and regtested fine?
>
> Peter
>
>
> libsanitizer/
>         * configure.tgt: Enable build on powerpc*-linux.
>
> gcc/
>         * config/rs6000/sysv4.h (TARGET_ASAN_SHADOW_OFFSET): Define.
>         * config/rs6000/rs6000.c (rs6000_asan_shadow_offset): New function.
>         * config/rs6000/rs6000.h (FRAME_GROWS_DOWNWARD): Define to
>         flag_stack_protect != 0 || flag_asan != 0.

Please change the FRAME_GROWS_DOWNWARD ChangeLog entry to something
more descriptive, not simply copying the macro line itself.  Maybe:
"Also disable if ASAN used."

Okay with that change.

Thanks, David
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]