This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Sun, 25 Nov 2012 23:09:03 +0100
- Subject: Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN
- References: <CABu31nMhyrBUwmNPAgg-AhZXyT29c5pdobfazAKCKq+RUjS6Gw@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Nov 25, 2012 at 12:59:48PM +0100, Steven Bosscher wrote:
> stop_search_p will reach the default case on DEBUG_INSN, and the
> default case is "gcc_unreachable()". I suppose this means nobody is
> using DWARF3+ on a dbr_sched target, it can't possibly ever have
> worked. Eric?
Isn't dbr scheduling after var-tracking, which removes DEBUG_INSNs (and
instead adds NOTE_INSN_VAR_LOCATION and NOTE_INSN_CALL_ARG_LOCATION notes)?
So, your patch is unnecessary.
> Anyway, also obvious: Don't stop on DEBUG_INSNs.
>
> * reorg.c (stop_search_p): Don't crash on DEBUG_INSNs.
>
> Index: reorg.c
> ===================================================================
> --- reorg.c (revision 193787)
> +++ reorg.c (working copy)
> @@ -260,6 +260,7 @@ stop_search_p (rtx insn, int labels_p)
> {
> case NOTE:
> case CALL_INSN:
> + case DEBUG_INSN:
> return 0;
>
> case CODE_LABEL:
Jakub