This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Committed: handle negative numbers in gcc-gdb-test.exp
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sat, 24 Nov 2012 04:41:25 -0500 (EST)
- Subject: Committed: handle negative numbers in gcc-gdb-test.exp
Without this, I got weird ERRORs and those Tcl backtraces you come
to hate, instead of the expected FAILs. Committed as obvious after
running a failing guality test and obvserving the intended change.
(Well ok, *adding an explanatory comment* is apparently not obvious,
but I'll take that liberty...)
testsuite:
* lib/gcc-gdb-test.exp (gdb-test): Pass -- as first argument
to to send_log.
Index: gcc/testsuite/lib/gcc-gdb-test.exp
===================================================================
--- gcc/testsuite/lib/gcc-gdb-test.exp (revision 192677)
+++ gcc/testsuite/lib/gcc-gdb-test.exp (working copy)
@@ -74,7 +74,9 @@ proc gdb-test { args } {
if { $first == $second } {
pass "$testname"
} else {
- send_log "$first != $second\n"
+ # We need the -- to disambiguate $first from an option,
+ # as it may be negative.
+ send_log -- "$first != $second\n"
fail "$testname"
}
remote_close target
brgds, H-P