Re: VEC re-write [patch 01/25]

[Andrew Pinski <pinskia at gmail dot com>]

On Sun, Nov 18, 2012 at 9:12 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Sun, Nov 18, 2012 at 12:05 PM, Hans-Peter Nilsson <hp@bitrange.com> wrote:
>> On Sat, 17 Nov 2012, Diego Novillo wrote:
>>> I have now committed all 25 parts of this patch as rev 193595.  Please
>>> CC me on any problems that you think may be related to this rewrite.
>>
>> That seems to have trigged some bug in gcc-4.4-era.  See
>> PR55381.  There are a lot of suspicious warnings from vec.h.
>> It smells a bit like a host gcc bug, but I'll have to find a
>> newer version where it builds to confirm.  (If so, "hopefully"
>> it's as "simple" as upping the minimum host gcc version or
>> blacklisting gcc-4.4.x.)
>
> Yeah, I got those warnings in my sparc and hppa builds, but they are
> harmless.  Strictly speaking offsetof cannot be applied to non-PODs.
> The only thing that makes that class non-POD is the protected
> attribute, but that does not alter the physical layout.  So the
> compiler is emitting a harmless warning (newer versions have
> tightened the check to warn when you are using offsetof on a non-base
> class).

But then we are no longer writing in C++.   Is there a reason why this
warning does not break the build?  We should not be using offsetof
with non-PODs.

Thanks,
Andrew Pinski

>
> My cris-elf builds worked fine, but config-list.mk only builds stage
> 1, it does not build libgfortran.  Can you give me instructions on how
> to build your target on my x86 workstation?
>
>
> Thanks.  Diego.