This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR other/55333: libsanitizer StackTrace::FastUnwindStack wrong x32
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, konstantin dot s dot serebryany at gmail dot com
- Date: Thu, 15 Nov 2012 06:02:28 -0800
- Subject: Re: PATCH: PR other/55333: libsanitizer StackTrace::FastUnwindStack wrong x32
- References: <20121115035105.GA17255@gmail.com> <20121115092639.GP1886@tucnak.redhat.com>
On Thu, Nov 15, 2012 at 1:26 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Nov 14, 2012 at 07:51:05PM -0800, H.J. Lu wrote:
>> X32 uses 32-bit pointer in software. But its hardware pointer is
>> 64-bit. We must use hardware pointer to unwind frames. This patch
>> adds uhwptr for hardware pointer and uses it to unwind stack frames.
>> Tested on Linux/x32, Linux/x86-64 and Linux/ia32. Please review it
>> for upstream.
>
> IMNSHO libasan should just use libbacktrace for building backtraces (if
> available, or backtrace (3)), libbacktrace can be used even to symbolize
> the backtrace on the fly, without the need for additional scripts.
>
It is a good idea. In the meantime, we should fix libsanitizer
for x32.
--
H.J.