This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Performance patch for MIPS conditional move in expr.c


On Wed, 2012-11-14 at 12:00 -0800, Andrew Pinski wrote:

> I know exactly where this code comes from; I have looked at the
> benchmark as one of the reason why I add expand_cond_expr_using_cmove
> in the first place.  Anyways you should look into removing
> TARGET_PROMOTE_PROTOTYPES because I found that also fixes the problem
> mentioned here.
> 
> Thanks,
> Andrew Pinski

Removing TARGET_PROMOTE_PROTOTYPES looks interesting but I don't know if
it is possible for compatibility reasons.  I am still looking at my
example though, I see GCC doing:

andi	$5,$5,0x1
xori	$5,$5,0x1
movz	$2,$4,$5

When it should just do:

andi	$5,$5,0x1
movn	$2,$4,$5


Steve Ellcey
sellcey@mips.com



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]