This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][Revised] Enable libsanitizer on darwin


On Wed, Nov 14, 2012 at 8:09 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> Hi Alex,
>

> thanks, that's certainly helpful.  I'm primarily interested in porting
> to Solaris, both SPARC and x86.  Several things should be similar to
> Linux (both being ELF systems), while other areas are certainly
> different (syscalls implementation etc.).
We don't wrap the syscalls in ASan, if you're speaking about that.

> I'll certainly be looking around.  One problem I see with the current
> code organization is duplication between different platforms:
> e.g. considerable parts of sanitizer_mac.cc and a new
> sanitizer_solaris.cc are identical.  Perhaps we need more granularity in
> the future, but that can be decided once an initial port (with
> duplication to avoid treading on other port's feet) is done.  At the
> same time, we should add infrastructure (like libffi) to only compile
> target-specific code on the relevant platforms, instead of wrapping
> every source file in #ifdef __linux__ or similar and extending the
> conditionals once a new platform is added.
Yes, this might be a problem. I also wonder how much Solaris is like
FreeBSD, which users are also interested in ASan.

-- 
Alexander Potapenko
Software Engineer
Google Moscow


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]