This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR other/55291: Add support for GCC multilib run-time libraries to libsanitizer
Il 14/11/2012 00:27, H.J. Lu ha scritto:
> On Tue, Nov 13, 2012 at 3:19 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>> Il 14/11/2012 00:16, H.J. Lu ha scritto:
>>>>> What has to be fixed about it? Anything except AC_PREREQ/AC_CONFIG_AUX_DIR?
>>>>>
>>>>> I really would prefer to do it in the order I mentioned above.
>>> We also need
>>>
>>> [hjl@gnu-tools-1 libsanitizer]$ cat acinclude.m4
>>> dnl ----------------------------------------------------------------------
>>> dnl This whole bit snagged from libgfortran.
>>>
>>> sinclude(../libtool.m4)
>>> dnl The lines below arrange for aclocal not to bring an installed
>>> dnl libtool.m4 into aclocal.m4, while still arranging for automake to
>>> dnl add a definition of LIBTOOL to Makefile.in.
>>> ifelse(,,,[AC_SUBST(LIBTOOL)
>>> AC_DEFUN([AM_PROG_LIBTOOL])
>>> ])
>>> [hjl@gnu-tools-1 libsanitizer]$
>>>
>>> Otherwise, autoconf won't work.
>>
>> Sure, that's fine to include too.
>>
>
> We need all changes in:
>
> * acinclude.m4: New file.
> * Makefile.am (ACLOCAL_AMFLAGS): New.
> * configure.ac (AC_PREREQ): Set to 2.64.
> (AC_CONFIG_AUX_DIR): Set to "..".
> (--enable-version-specific-runtime-libs): New option.
> (AC_CANONICAL_SYSTEM): New.
> (AM_ENABLE_MULTILIB): Moved right after AM_INIT_AUTOMAKE.
> (toolexecdir): Support multilib.
> (toolexeclibdir): Likewise.
>
> Missing one will cause a problem.
I don't understand why removing files needs
--enable-version-specific-runtime-libs or multilibs.
Paolo