This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR other/55292: libsanitizer doesn't support x32
On Mon, Nov 12, 2012 at 6:59 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Mon, Nov 12, 2012 at 6:02 PM, Diego Novillo <dnovillo@google.com> wrote:
>> On Mon, Nov 12, 2012 at 6:36 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> Hi,
>>>
>>> Linux/x32 doesn't have __NR_mmap2/__NR_fstat64 and uses
>>> __NR_mmap/__NR_fstat, just like Linux/x86-64. Tested on Linux/x32.
>>> OK to install?
>>
>> Patches to libsanitizer should be sent upstream. We should only
>> contain a copy of the master in the LLVM repository. There should be
>> instructions in libsanitizer/README.gcc (Jakub, Dodji, are they there?
>> I can't check ATM).
>
> I rather hate having to submit changes like this in two different
> places. Why can't the people who added the target library like this
> take responsibility for doing the merges from the GCC source to the
> upstream? Like libffi is handled.
>
Agreed. I created a git branch, hjl/asan, to address those issues.
It compiles/installs fine on Linux/x32 with lib, lib64 and libx32:
[hjl@gnu-tools-1 gcc-4.8.0-x32]$ file */libasan*.0.0.0
lib64/libasan.so.0.0.0: ELF 64-bit LSB shared object, x86-64, version
1 (GNU/Linux), dynamically linked,
BuildID[sha1]=0xd397454af874d82e45bffde03c18870588e9d901, not stripped
lib/libasan.so.0.0.0: ELF 32-bit LSB shared object, Intel 80386,
version 1 (GNU/Linux), dynamically linked,
BuildID[sha1]=0x7b0c7b7793d3284cfad63f1a11bff1b814c3ac9a, not stripped
libx32/libasan.so.0.0.0: ELF 32-bit LSB shared object, x86-64, version
1 (GNU/Linux), dynamically linked,
BuildID[sha1]=0x699fa9a47f7cc24f9ff82c8663ecdf935b0f43a4, not stripped
[hjl@gnu-tools-1 gcc-4.8.0-x32]$
I am afraid that configure.ac change is very much specific to
compiling libsanitizer as a GCC target library. Could someone
submit those changes upstream on behalf of GCC project?
Thanks.
--
H.J.