This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

From: Jason Merrill <jason at redhat dot com>
To: Sriraman Tallam <tmsriram at google dot com>
Cc: David Li <davidxl at google dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <jh at suse dot cz>, Diego Novillo <dnovillo at google dot com>
Date: Mon, 12 Nov 2012 21:39:08 -0500
Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064)
References: <CAAs8HmxHF38ktt6syjWp-MpjiX+6NcXh7_8Xn6iKnAiF2vRymQ@mail.gmail.com> <CAAs8HmxEod=EJNyUjrD0-WaP0-cB5o_AN9oc2O2ryu--MRQf4w@mail.gmail.com> <CAAs8Hmyy9S+Ucg6rTDU3xGMg8JEaa0r3rNjbxhbjuk9H8Sb6wg@mail.gmail.com> <50816D63.3020908@google.com> <CAAs8HmzZUnGq9G3KQ-wesKOHVWJBHn1n0zyFhEOPxo+i0PBrww@mail.gmail.com> <CAAs8HmxXfBdsLOrhEnd=syUXfbo5gKa-QkdWQG=4bUeWOPrSfQ@mail.gmail.com> <20121026155447.GA4348@atrey.karlin.mff.cuni.cz> <CAAs8Hmw0KBhKp_3qe0gzVi1jw=LVg6GD1cv-++=Kh3OjThwB+A@mail.gmail.com> <50902624.3020705@redhat.com> <CAAs8Hmw09giv-5_v0irhByTjTJV=kD58rCAD2SAz7M8zrwjBOA@mail.gmail.com> <50912F66.3030707@redhat.com> <CAAs8Hmz4CNzyJHAPoRkEe5gtL3YXSqoNHGMeZdm0uJujFHkMhQ@mail.gmail.com> <CAAs8Hmz7aDcN+2YGfH8ixrgUt+A=PuTt8ZzPhUVeQTgSWGP-Ww@mail.gmail.com> <50993222.3010609@redhat.com> <CAAs8Hmw-WXwbgUvwmegd680i0rT8CG2M=XYRa1V5ejMqbRd1Bw@mail.gmail.com> <50A08349.4070101@redhat.com> <CAAs8Hmwa80GxP=eHEq0KZSKqA4Y9QtfbU-ATx1g42PRTpcjkuA@mail.gmail.com>

On 11/12/2012 08:11 PM, Sriraman Tallam wrote:

+	    && !targetm.target_option.function_versions (fn,
+	         TREE_PURPOSE (match)))

The second argument should be lined up with the left paren if it's on a different line. Perhaps formatting this as

&& !(targetm.target_option.function_versions
     (fn, TREE_PURPOSE (match))))

would be better.

+      error_at (input_location, "Use of multiversioned function "
+	    "Multiversioning needs ifunc which is not supported "

We don't capitalize the first letter of a diagnostic.

OK with those changes.

Jason

Follow-Ups:
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Sriraman Tallam

References:
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Sriraman Tallam
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Sriraman Tallam
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Jason Merrill
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Sriraman Tallam
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Jason Merrill
- Re: User directed Function Multiversioning via Function Overloading (issue5752064)
  - From: Sriraman Tallam

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]