This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386]: Fix PR 55247, ICE: Max. number of generated reload insns per insn is achieved
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Vladimir Makarov <vmakarov at redhat dot com>
- Date: Sat, 10 Nov 2012 10:58:31 -0800
- Subject: Re: [PATCH, i386]: Fix PR 55247, ICE: Max. number of generated reload insns per insn is achieved
- References: <CAFULd4ZspJPQ7rpG1Nx83TL0bWKRE0rkbBSBbS1FVxifjfbwvA@mail.gmail.com>
On Sat, Nov 10, 2012 at 3:43 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
> Attached patch disparages riF->o alternative of *movti_internal_rex64
> insn, as described by Vlad in comment #2 [1]
>
> The core of the problem however is, that gcc is unable to detect
> zero-extended address as offsetable. H.J. will propose a patch for
> this [2].
My updated patch is at
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00799.html
> 2012-11-10 Vladimir Makarov <vmakarov@redhat.com>
> Uros Bizjak <ubizjak@gmail.com>
>
> PR target/55247
> * config/i386/i386.md (*movti_internal_rex64): Add "!" to riF->o
> alternative.
>
> testsuite/ChangeLog:
>
> 2012-11-10 Uros Bizjak <ubizjak@gmail.com>
>
> PR target/55247
> * gcc.target/i386/pr55247.c: New test.
>
> Tested on x86_64-linux-gnu {,m32} and committed to mainline SVN.
>
> [1] gcc.gnu.org/bugzilla/show_bug.cgi?id=55247#c2
> [2] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55247#c6
>
> Uros.
I checked in this patch to compile pr55247.c with -mno-sse -mno-mmx,
which triggers the bug.
H.J.
--
Index: ChangeLog
===================================================================
--- ChangeLog (revision 193393)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2012-11-10 H.J. Lu <hongjiu.lu@intel.com>
+
+ * gcc.target/i386/pr55247.c: Require maybe_x32 target. Add
+ -mno-sse -mno-mmx to dg-options. Reformat.
+
2012-11-10 David Edelsohn <dje.gcc@gmail.com>
* c-c++-common/scal-to-vec2.c: Ignore non-standard ABI message.
Index: gcc.target/i386/pr55247.c
===================================================================
--- gcc.target/i386/pr55247.c (revision 193393)
+++ gcc.target/i386/pr55247.c (working copy)
@@ -1,8 +1,8 @@
/* { dg-do compile { target { ! { ia32 } } } } */
-/* { dg-options "-O2 -mx32 -maddress-mode=long -mno-sse" } */
+/* { dg-require-effective-target maybe_x32 } */
+/* { dg-options "-O2 -mno-sse -mno-mmx -mx32 -maddress-mode=long" } */
typedef unsigned int uint32_t;
-typedef unsigned int uintptr_t;
typedef uint32_t Elf32_Word;
typedef uint32_t Elf32_Addr;
typedef struct {
@@ -16,7 +16,7 @@
}
Elf32_Rela;
typedef struct {
- union {
+ union {
Elf32_Addr d_ptr;
}
d_un;
@@ -24,15 +24,12 @@
struct link_map {
Elf32_Dyn *l_info[34];
};
-typedef struct link_map *lookup_t;
extern void symbind32 (Elf32_Sym *);
void
_dl_profile_fixup (struct link_map *l, Elf32_Word reloc_arg)
{
- const Elf32_Sym *const symtab = (const void *) (l)->l_info[6]->d_un.d_ptr;
- const Elf32_Rela *const reloc = (const void *)
((l)->l_info[23]->d_un.d_ptr + reloc_arg * sizeof (Elf32_Rela));
- const Elf32_Sym *refsym = &symtab[((reloc->r_info) >> 8)];
- const Elf32_Sym *defsym = refsym;
- Elf32_Sym sym = *defsym;
+ const Elf32_Sym *const symtab = (const void *) l->l_info[6]->d_un.d_ptr;
+ const Elf32_Rela *const reloc = (const void *)
(l->l_info[23]->d_un.d_ptr + reloc_arg * sizeof (Elf32_Rela));
+ Elf32_Sym sym = symtab[(reloc->r_info) >> 8];
symbind32 (&sym);
}