This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix up assembly thunks with -gstabs+ (PR debug/54499)


jakub> 2012-11-08  Jakub Jelinek  <jakub@redhat.com>
jakub>
jakub>       PR debug/54499
jakub>       * cgraphunit.c (assemble_thunk): Don't call source_line debug hook
jakub>       here, instead call insn_locations_{init,finalize} and initialize
jakub>       prologue_location.
jakub>
jakub>       * g++.dg/debug/pr54499.C: New test.

Thanks, Jakub, this does look like a better fix. I had tried something
like this, but it didn't work -- I was missing the _init and _finalize
calls, and I didn't set prologue_location either.

rth> I recall mentioning at the time that I thought Cary's approach
was error-prone.

Well, yes, you did, but then you backed off after I tested an ARM compiler:

On Mon, Aug 6, 2012 at 2:53 PM, Richard Henderson <rth@redhat.com> wrote:
> On 08/06/2012 02:45 PM, Cary Coutant wrote:
>> Do you still have concerns about the patch?
>
> Nope.  I'd mis-remembered from whence things get finalized.
>
> Revised patch is ok.

I do agree with you, though, that it would still be better to treat
thunks as first-class objects.

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]