This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Remove unused ebitmap and unused sbitmap functions.
- From: Lawrence Crowl <crowl at googlers dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: Richard Biener <rguenther at suse dot de>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Nov 2012 11:06:54 -0700
- Subject: Re: [patch] Remove unused ebitmap and unused sbitmap functions.
- References: <CAGqM8fZ2WVDrQ-hQwE8tMYpst_bHTPGKivWh=LtuxyvvLZ8BCw@mail.gmail.com> <50927F57.5080000@google.com>
On 11/1/12, Diego Novillo <dnovillo@google.com> wrote:
> On 2012-10-31 18:47 , Lawrence Crowl wrote:
>> 2012-10-31 Lawrence Crowl <crowl@google.com>
>>
>> * ebitmap.h: Remove unused.
>> * ebitmap.c: Remove unused.
>> * Makefile.in: Remove ebitmap.h and ebitmap.c.
>> * sbitmap.h (SBITMAP_SIZE_BYTES): Move to source file.
>> (SET_BIT_WITH_POPCOUNT): Remove unused.
>> (RESET_BIT_WITH_POPCOUNT): Remove unused.
>> (bitmap_copy_n): Remove unused.
>> (bitmap_range_empty_p): Remove unused.
>> (sbitmap_popcount): Remove unused.
>> (sbitmap_verify_popcount): Make private to source file.
>> * sbitmap.c (SBITMAP_SIZE_BYTES): Move here from header.
>> (bitmap_copy_n): Remove unused.
>> (bitmap_range_empty_p): Remove unused.
>> (sbitmap_popcount): Remove unused.
>> (sbitmap_verify_popcount): Make private to source file.
>>
>> Index: gcc/sbitmap.c
>> ===================================================================
>> --- gcc/sbitmap.c (revision 193049)
>> +++ gcc/sbitmap.c (working copy)
>> @@ -22,6 +22,9 @@ along with GCC; see the file COPYING3.
>> #include "coretypes.h"
>> #include "sbitmap.h"
>>
>> +/* Return the set size needed for N elements. */
>> +#define SBITMAP_SIZE_BYTES(BITMAP) ((BITMAP)->size * sizeof
>> (SBITMAP_ELT_TYPE))
>> +
>
> Not terribly important, but maybe take advantage of the change and
> convert it into a static inline function?
Sure.
> OK, otherwise.
I will merge and commit.
--
Lawrence Crowl