This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Normalize more bitmap function names.

From: Diego Novillo <dnovillo at google dot com>
To: Lawrence Crowl <crowl at googlers dot com>
Cc: Richard Biener <rguenther at suse dot de>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Thu, 01 Nov 2012 10:25:09 -0400
Subject: Re: [patch] Normalize more bitmap function names.
References: <CAGqM8fatObp7ZvxZC9Ypq6=Q92pkyyQbPMwP-A9iU_x1=OX_aA@mail.gmail.com>

On 2012-10-31 13:41 , Lawrence Crowl wrote:

This patch normalizes more bitmap function names.

sbitmap.h
     TEST_BIT -> bitmap_bit_p
     SET_BIT -> bitmap_set_bit

I wonder if it wouldn't it be more consistent if TEST_BIT became bitmap_test_bit() ? I never particularly liked the lispy *_p convention. But I don't really care much one way or the other.

The patch is OK.

Diego.

Follow-Ups:
- Re: [patch] Normalize more bitmap function names.
  - From: Lawrence Crowl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]