This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Committed: Fix sh regression for target/55160
On Thu, 2012-11-01 at 05:18 -0400, Joern Rennecke wrote:
> Quoting Oleg Endo <oleg.endo@t-online.de>:
>
> > I'd like to add a test case for this.
> >
> > Attached patch was tested with
> > make -k check-gcc RUNTESTFLAGS="sh.exp=pr55160.c --target_board=sh-sim
> > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}"
> >
> > OK to install?
>
> That'll be for the SH maintainers to decide.
>
> However, I note that dg-skip-if is used with negated logic from what is
> described in:
> http://gcc.gnu.org/onlinedocs/gccint/Directives.html
>
> Is that a documentation bug?
I'm using:
/* { dg-skip-if "" { "sh*-*-*" } { "-m5*"} { "" } } */
Documentation says:
{ dg-skip-if comment { selector } [{ include-opts } [{ exclude-opts }]] }
For example, to skip a test if option -Os is present:
/* { dg-skip-if "" { *-*-* } { "-Os" } { "" } } */
Has been working for me as described in the docs so far (there are more
SH tests that use dg-skip-if, e.g. to skip SH2A tests when not compiling
for SH2A etc).
Cheers,
Oleg