This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR53914, rs6000 constraints and reload queries
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 29 Oct 2012 16:06:28 -0400
- Subject: Re: PR53914, rs6000 constraints and reload queries
- References: <20120717153411.GB27761@bubble.grove.modra.org> <201207171629.q6HGTWa0024234@d06av02.portsmouth.uk.ibm.com> <20120719030425.GE27761@bubble.grove.modra.org> <20120719143528.GA3182@bubble.grove.modra.org> <20120720004539.GB3182@bubble.grove.modra.org> <CAGWvnyke4K8HTmeEkibXM1Us2NxLmJCz0wA8k5mSUWU-cpxdmA@mail.gmail.com> <20120723004205.GC3182@bubble.grove.modra.org> <CAGWvny=HMK6igkNNcBkDaoTK1LqE9TFLea8a=b6BkXAnhOEv1w@mail.gmail.com> <20120724060718.GG3182@bubble.grove.modra.org> <20120801135244.GA3182@bubble.grove.modra.org>
On Wed, Aug 1, 2012 at 9:52 AM, Alan Modra <amodra@gmail.com> wrote:
> Hi David,
> This is the last of my vendetta against the "o" constraint in the
> rs6000 backend. Remaining are a few places in rs6000.md where the
> operand predicate is offsettable_mem_operand, and one instance in
> spe.md. I believe none of these can run into mode_dependent_address
> causing "insn does not statisfy its constraints". Also, with "Y"
> replacing "o" everywhere a 64-bit gpr is loaded or stored, we can
> remove the +0 wrapper you added for pr13674.
>
> I also add some testcases with this patch. dfmode_off and tfmode_off
> will fail on e500, but the generated code at -O2 is so awful that I'm
> inclined to think it should remain that way until someone fixes it!
>
> Bootstrapped and regression tested powerpc64-linux. OK to apply?
>
> gcc/
> * config/rs6000/rs6000.c (legitimize_reload_address): Remove code
> handling non-aligned ld/std.
> * config/rs6000/paired.md (movv2sf_paired): Use 'Y' instead of 'o'.
> * config/rs6000/vsx.md (vsx_mov, vsx_movti): Likewise.
> * config/rs6000/altivec.md (altivec_mov, altivec_movti): Likewise.
> * config/rs6000/dfp.md (movtd_internal): Use 'm' instead of 'o'.
> gcc/testsuite/
> * gcc.target/powerpc/dimode_off.c: New.
> * gcc.target/powerpc/timode_off.c: New.
> * gcc.target/powerpc/dfmode_off.c: New.
> * gcc.target/powerpc/tfmode_off.c: New.
This is okay.
Thanks, David