This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix libbacktrace on 32-bit sparc
From: Ian Lance Taylor <firstname.lastname@example.org>
Date: Mon, 29 Oct 2012 08:43:42 -0700
> This patch should fix it. Bootstrapped and ran libbacktrace testsuite
> on x86_64-unknown-linux-gnu. Committed to mainline.
I can tell just by looking at your patch that it doesn't fix the
It's "vec->base + vec->size" that's not aligned, rather than the
length. All your change does it align the length term.
You have to align the vec->size term in the pointer computation.
Actually you need to align both.
First you have to align vec->size to an 8 byte boundary. Then
you have to align the remaining length that results to an 8
byte boundary as well.
Can you post a test patch for me this time, instead of just committing
a change which hasn't been tested to fix the problem? I'd very much