This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Unify bitmap interface.


On 10/25/12, Lawrence Crowl <crowl@googlers.com> wrote:
> This patch implements the unification of the *bitmap interfaces as
> discussed.
> Essentially, we rename ebitmap and sbitmap functions to use the same names
> as the bitmap functions.  This rename works because we can now overload
> on the bitmap type.  Some macros now become inline functions to enable
> that overloading.
>
> The sbitmap non-bool returning bitwise operations have been merged with
> the bool versions.  Sometimes this merge involved modifying the non-bool
> version to compute the bool value, and sometimes modifying bool version to
> add additional work from the non-bool version.  The redundant routines have
> been ifdef'd out.  I will remove the ifdef'd out code later.
>
> The allocation functions have not been renamed, because we often do not
> have an argument on which to overload.  The cardinality functions have not
> been renamed, because they have different parameters, and are thus not
> interchangable.  The iteration functions have not been renamed, because
> they are functionally different.
>
> Tested on x86_64.  Config testing in progress.

Config testing has only 3 failures, all unrelated.

-- 
Lawrence Crowl


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]