This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Unify bitmap interface.
- From: Lawrence Crowl <crowl at googlers dot com>
- To: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Diego Novillo <dnovillo at google dot com>
- Date: Fri, 26 Oct 2012 17:08:08 -0700
- Subject: Re: [patch] Unify bitmap interface.
- References: <CAGqM8fYNSriDV4a9UdrqgdKwJGYYhW+xE4DbFuokmixYxnGmfQ@mail.gmail.com>
On 10/25/12, Lawrence Crowl <crowl@googlers.com> wrote:
> This patch implements the unification of the *bitmap interfaces as
> discussed.
> Essentially, we rename ebitmap and sbitmap functions to use the same names
> as the bitmap functions. This rename works because we can now overload
> on the bitmap type. Some macros now become inline functions to enable
> that overloading.
>
> The sbitmap non-bool returning bitwise operations have been merged with
> the bool versions. Sometimes this merge involved modifying the non-bool
> version to compute the bool value, and sometimes modifying bool version to
> add additional work from the non-bool version. The redundant routines have
> been ifdef'd out. I will remove the ifdef'd out code later.
>
> The allocation functions have not been renamed, because we often do not
> have an argument on which to overload. The cardinality functions have not
> been renamed, because they have different parameters, and are thus not
> interchangable. The iteration functions have not been renamed, because
> they are functionally different.
>
> Tested on x86_64. Config testing in progress.
Config testing has only 3 failures, all unrelated.
--
Lawrence Crowl