This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR c++/54928 infinite ICE when reporting ICE on macro expansion
I am not a maintainer so the below are just some casual comments of
mine. I am deferring to the maintainers for a real review.
Manuel LÃpez-IbÃÃez <lopezibanez@gmail.com> writes:
> gcc/
> * tree-diagnostic.c (maybe_unwind_expanded_macro_loc):
> Use diagnostic_attach_note.
> * diagnostic.c (diagnostic_build_prefix): Make diagnostic const.
> (default_diagnostic_finalizer): Do not destroy prefix here.
> (diagnostic_report_diagnostic): Destroy it here.
> (diagnostic_attach_note): New.
> * diagnostic.h (diagnostic_attach_note): Declare.
>
These bits looks good to me, barring ...
[...]
> +void
> +diagnostic_attach_note (diagnostic_context *context,
> + location_t location,
> + const char * gmsgid, ...)
> +{
... this function that lacks a comment.
Thanks.
--
Dodji