This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 54224: [4.8 Regression] Bogus -Wunused-function warning with static function
Hi Tobias,
>> I have found a fix that is rather trivial in the sense that it's a
>> one-liner.
>
>
> I think it is the proper fix.
good :)
>> However, it may not be as trivial conceptually (in particular I'm not 100%
>> sure what caused this regression in the first place
>
>
> I think it is the combination of having "static" noninternal procedures
> (which is a new 4.8 feature) combined with the middle-end assumption that
> the FE marks procedures as TREE_USED. (The ME does mark them as TREE_USED,
> but too late.)
>
> (The other question is why the diagnostic doesn't work for internal
> procedures - or for GNU C's nested function. I think also for module
> variables such a diagnostic would be useful. However, both are just missed
> diagnostics and not diagnostic-output regressions.)
these things we should follow-up on in the PR, or are there other PRs for these?
>> Anyway, it regtests cleanly and fixes the problem as advertised. Ok for
>> trunk?
>
>
> Yes. Thanks for the patch.
Thanks. Committed as r192620.
Cheers,
Janus