Re: [asan] Emit GIMPLE directly, small cleanups

[Diego Novillo <dnovillo at google dot com>]

On 2012-10-16 07:05 , Rainer Orth wrote:
> Diego Novillo <dnovillo@google.com> writes:
>
> > On Mon, Oct 15, 2012 at 11:55 AM, Ian Lance Taylor <iant@google.com> wrote:
> >
> > > In my opinion, supporting the full range of GCC testsuite annotations
> > > means imposing a lot of mechanism that the Go testsuite does not
> > > require.  It would complicate the Go testsuite for no benefit.
> > > Anybody who can understand the GCC testsuite annotations can
> > > understand the much simpler Go testsuite annotations.
> >
> > Agreed.  The fact that we have to suffer DejaGNU does not gives the
> > right to make other projects miserable.
>
> But importing different upstream testsuites with different annotation
> systems allows them to make GCC maintainer's lives miserable?

Yes, absolutely.  We have to adapt to upstream's conventions.  If that 
means putting translation layers, the onus is on us.

Alternately, we could import libasan the same way we import things like 
zlib or boehm-gc and then re-write the testsuite.  That makes it harder 
to import newer versions, however.

Finally, we could simply duplicate libasan's testsuite inside 
gcc/testsuite/asan and add our own tests as well.  This may be the more 
practical choice.


Diego.