This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, i386]: Fix PR51109, symbol size in scheduler state machine is reduced

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: "Gopalasubramanian, Ganesh" <Ganesh dot Gopalasubramanian at amd dot com>, Uros Bizjak <ubizjak at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, vekumar at gcc dot gnu dot org
Date: Wed, 10 Oct 2012 12:57:09 +0200
Subject: Re: [PATCH, i386]: Fix PR51109, symbol size in scheduler state machine is reduced
References: <EB4625145972F94C9680D8CADD6516152A36BE71@sausexdag04.amd.com> <CAFULd4ZAifzHt_KzfHKE06qa87-QgarKFqtiDuCxpZqykthKWw@mail.gmail.com> <EB4625145972F94C9680D8CADD6516152A36D123@sausexdag04.amd.com> <50754DF0.6060701@oracle.com> <20121010105316.GW26735@tucnak.redhat.com>

Hi,

On 10/10/2012 12:53 PM, Jakub Jelinek wrote:

Yeah, clearly a different version of the patch has been posted
vs. what has been checked in.  The difference is removal of the
(define_cpu_unit "bdver1-mult" "bdver1_mult")
line (present in the posted patch, not in the checked in patch).

Also, the ChangeLog entry is wrong:
	PR 51109
	* gcc/config/i386/bdver1.md (bdver1_int): Automaton has been
	split to reduce state transitions.
- should start with:
	PR target/51109
	* config/i386/bdver1.md
and really document the changes it has done, or just not contain
(bdver1_int) and document the file changes.

And Copyright year hasn't been updated (but this wasn't first
commit in 2012, others made the same mistake, no changes in 2011
btw).

Shall we (I) just revert the change for now?

Thanks,
Paolo.

Follow-Ups:
- Re: [PATCH, i386]: Fix PR51109, symbol size in scheduler state machine is reduced
  - From: Jakub Jelinek

References:
- RE: [PATCH, i386]: Fix PR51109, symbol size in scheduler state machine is reduced
  - From: Gopalasubramanian, Ganesh
- Re: [PATCH, i386]: Fix PR51109, symbol size in scheduler state machine is reduced
  - From: Paolo Carlini
- Re: [PATCH, i386]: Fix PR51109, symbol size in scheduler state machine is reduced
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]