This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables

From: Uros Bizjak <ubizjak at gmail dot com>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: Ian Lance Taylor <iant at google dot com>, gcc-patches at gcc dot gnu dot org
Date: Tue, 2 Oct 2012 11:01:19 +0200
Subject: Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables
References: <CAFULd4aKtW8iRPRO56tF-0Qj8+63eK5sKj3-hNiBMOvOKrQuGQ@mail.gmail.com> <m2sj9xthy0.fsf@igel.home>

On Tue, Oct 2, 2012 at 10:08 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:

>> +if test "x$GCC" = "xyes"; then
>> +  CFLAGS="$CFLAGS -funwind-tables"
>> +fi
>> +
>
> Don't modify CFLAGS, instead you should substitute a new variable that
> is added to AM_CFLAGS.  CFLAGS is reserved for the user to override.

Thanks, attached is a version that introduces EXTRA_FLAGS instead.

2012-10-02  Uros Bizjak  <ubizjak@gmail.com>

        PR other/54761
        * configure.ac (EXTRA_FLAGS): New.
	* Makefile.am (AM_FLAGS): Add $(EXTRA_FLAGS).
        * configure, Makefile.in: Regenerate.

Testing on {x86_64,alphaev68}-linux-gnu in progress.

Uros.

Attachment: i.diff.txt
Description: Text document

Follow-Ups:
- Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables
  - From: Ian Lance Taylor

References:
- [PATCH v2, libbacktrace]: Compile with -funwind-tables
  - From: Uros Bizjak
- Re: [PATCH v2, libbacktrace]: Compile with -funwind-tables
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]