This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Use conditional casting with symtab_node

On Thu, Sep 20, 2012 at 1:53 PM, Lawrence Crowl <crowl@googlers.com> wrote:

>> > Why do you think cascading ifs is a bad idea?
>>
>> Precedent.  Confusion in case of dangling else (requiring more {},
>> and hence even more indentation).  Ugly.
>
> I generally take ugly as an indication that the function needs
> refactoring.

Hear!  Hear! Hear!

Sadly, many functions in GCC (at least in cp/) are in that category :-(

-- Gaby
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]