This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.7 PATCH] Use automake no-dist everywhere
On Thu, Sep 20, 2012 at 09:12:37AM -0700, Ian Lance Taylor wrote:
> On Thu, Sep 20, 2012 at 6:33 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> >
> > This is the 4.7 version. Not 100% sure about libgo, Ian, are you regularly
> > syncing upstream libgo even into 4.7 branch, or only to trunk? I.e. are you
> > find with this kind of change for libgo, or do you want to do such a change
> > upstream, or do you need make dist/distcheck upstream and will take care of
> > regenerating stuff with automake 1.11.6 or later?
>
> I am regularly syncing libgo patch fixes into both mainline and the
> 4.7 branch, only not right now because the 4.7 branch is closed
> (unless I'm out of date). If you want to commit this to the 4.7
> branch now while it is closed, go ahead, and I will catch up.
> Normally I think it's preferable to make the change upstream first.
Ok, I'll leave libgo out from the patch and let you handle that on the 4.7
branch then. It needs to be resolved before 4.7.3 release in a few months
(and on trunk before 4.8.0 release).
Note that at this point the rejection reason was
http://git.savannah.gnu.org/cgit/automake.git/commit/?id=784b3e6ccc7c72a1c95c340cbbe8897d6b689d76
i.e.
chmod -R a-w $(distdir); chmod a+w $(distdir)
line in the Makefile.in instead of
chmod -R a-w $(distdir); chmod u+w $(distdir)
But as this is not the first issue in the make dist* stuff, if you can, just
disable it altogether ;).
Jakub