This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] support using "target" and "xfail" together


On Sep 19, 2012, at 10:35 AM, Janis Johnson <janis_johnson@mentor.com> wrote:
> On 07/24/2012 11:13 AM, Janis Johnson wrote:
>> This patch allows the use of both "target" and "xfail" in the selector
>> of any test directive that currently takes either "target" or "xfail":
>> 
>>  { target selector1 xfail selector2 }
>> 
>> The test is only used if the "target" selector is matched, and the test
>> is expected to fail if the "xfail" selector is matched.  The keyword
>> "target" must come first; it doesn't make sense to me otherwise because
>> the xfail part shouldn't be processed if the target selector doesn't
>> match.
>> 
>> Tested with i686-pc-linux-gnu for c,c++,gfortran,objc,obj-c++ plus with
>> examples using the new feature, with and without errors.
>> 
>> I'd like some feedback before checking this in so I'll wait at least a
>> couple of days.  I plan to put it on the 4.7 branch also.
> 
> I'd still like some feedback; I guess I lied when I said I'd check it
> in anyway.

I like it.  What's not to like?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]