This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Changes in mode switching
> Looks OK to me, though I have no authority to approve it
> except SH specific part.
Is there any more comments? Can it be committed in trank?
Regards,
Vladimir
2012/9/14 Kaz Kojima <kkojima@rr.iij4u.or.jp>:
> Vladimir Yakovlev <vbyakovl23@gmail.com> wrote:
>> I reproduced the failure and found reason of it. I understood haw it
>> resolve and now I need small changes only - additional argument of
>> EMIT_MODE_SET. Is it good fo trunk?
>>
>> Thank you,
>> Vladimir
>>
>> 2012-09-14 Vladimir Yakovlev <vladimir.b.yakovlev@intel.com>
>>
>> * (optimize_mode_switching): Added an argument EMIT_MODE_SET calls.
>>
>> * config/epiphany/epiphany.h (EMIT_MODE_SET): Added an argument.
>>
>> * config/i386/i386.h (EMIT_MODE_SET): Added an argument.
>>
>> * config/sh/sh.h (EMIT_MODE_SET): Added an argument.
>
> No new failures on sh4-unknown-linux-gnu with your patch.
> Looks OK to me, though I have no authority to approve it
> except SH specific part.
>
> BTW, I guess that the active voice is usual in gcc/ChangeLog.
> Also, perhaps mailer issue, a tab should be used for indentation
> instead of 8 spaces and the empty line isn't required between
> items. Maybe something like
>
> * mode-switching.c (optimize_mode_switching): Add an argument
> EMIT_MODE_SET calls.
> * config/epiphany/epiphany.h (EMIT_MODE_SET): Add an argument.
> * config/i386/i386.h (EMIT_MODE_SET): Likewise.
> * config/sh/sh.h (EMIT_MODE_SET): Likewise.
>
> is a usual form.
>
> Regards,
> kaz