This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR libstdc++/54576: random_device isn't protected by _GLIBCXX_USE_C99_STDINT_TR1

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: "H.J. Lu" <hongjiu dot lu at intel dot com>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Fri, 14 Sep 2012 11:47:42 +0200
Subject: Re: PR libstdc++/54576: random_device isn't protected by _GLIBCXX_USE_C99_STDINT_TR1
References: <20120914011642.GA32163@intel.com>

Hi,

On 09/14/2012 03:16 AM, H.J. Lu wrote:

Hi,

include/random has

#ifdef _GLIBCXX_USE_C99_STDINT_TR1

#include <cstdint> // For uint_fast32_t, uint_fast64_t, uint_least32_t
#include <bits/random.h>
#include <bits/random.tcc>

#endif // _GLIBCXX_USE_C99_STDINT_TR1

random_device is defined in <bits/random.h>. But src/c++11/random.cc
has

#include <random>
...
   void
   random_device::_M_init(const std::string& token)
   {

It doesn't check if _GLIBCXX_USE_C99_STDINT_TR1 is defined.  This
patch checks it.  OK to install?

I thought this was already history, because it's a Dup.

Anyway, the obvious patch is Ok, thanks, but please put a blank line right after "#ifdef _GLIBCXX_USE_C99_STDINT_TR1"-

Thanks!
Paolo.

References:
- PR libstdc++/54576: random_device isn't protected by _GLIBCXX_USE_C99_STDINT_TR1
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]